Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseSampleFormatter -- remove data_type parameter from ctor #181

Closed
nicolay-r opened this issue Aug 26, 2021 · 0 comments
Closed

BaseSampleFormatter -- remove data_type parameter from ctor #181

nicolay-r opened this issue Aug 26, 2021 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

There is no need to depend on data_type because:

  • We utilize it in logging only
  • Functionality required for columns organization and values filling in supported columns =>
    Implement ColumnsProvider instead of data_type parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r