Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseSampleStorage -- use store_labels instead of data_type passing (QUICK) #192

Closed
nicolay-r opened this issue Sep 17, 2021 · 0 comments
Closed

BaseSampleStorage -- use store_labels instead of data_type passing (QUICK) #192

nicolay-r opened this issue Sep 17, 2021 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Sep 17, 2021 •
edited
Loading

Reason: we check only is_train and hence there is no need in storing data_type.

Rated to #181

AREkit/arekit/common/experiment/input/storages/sample.py

Line 20 in fb44b8c

def __init__(self, data_type):

@nicolay-r nicolay-r added the enhancement New feature or request label Sep 17, 2021
@nicolay-r nicolay-r self-assigned this Sep 17, 2021
nicolay-r added a commit that referenced this issue Sep 17, 2021
@nicolay-r
Refactoring #192
933ba5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r