Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseRowsFormatter -- move format method in another class #185

Closed
nicolay-r opened this issue Aug 26, 2021 · 0 comments
Closed

BaseRowsFormatter -- move format method in another class #185

nicolay-r opened this issue Aug 26, 2021 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Aug 26, 2021 •
edited
Loading

Since BaseRowsFormatter -> BaseRowsStorage, we need to move formatter in another class.

  • pass __save_value as function that allows to save value by (row_ind, column)

Proceeds the #183
@nicolay-r nicolay-r added enhancement New feature or request task labels Aug 26, 2021
@nicolay-r nicolay-r self-assigned this Aug 26, 2021
nicolay-r added a commit that referenced this issue Sep 16, 2021
@nicolay-r
#183, #185, #190 related refactorings
fb44b8c
nicolay-r added a commit that referenced this issue Sep 17, 2021
@nicolay-r
#183, #185, #190 -- refactoring. test_input_balancing.py unittest is …
6c38f31 
…passed
nicolay-r added a commit that referenced this issue Sep 17, 2021
@nicolay-r
#183, #185, #190, #193 -- refactoring
f8785b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r