Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringLabelsFormatter -- switch to label_types instead of label instances. #223

Closed
nicolay-r opened this issue Dec 12, 2021 · 0 comments
Closed

StringLabelsFormatter -- switch to label_types instead of label instances. #223

nicolay-r opened this issue Dec 12, 2021 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

Since we compare labels, it is expected to compare by types.
@nicolay-r nicolay-r added enhancement New feature or request critical labels Dec 12, 2021
@nicolay-r nicolay-r self-assigned this Dec 12, 2021
nicolay-r added a commit that referenced this issue Dec 12, 2021
@nicolay-r
#223. Related, added parameters check.
0acb48a
@nicolay-r nicolay-r added the task label Dec 13, 2021
nicolay-r added a commit that referenced this issue Dec 14, 2021
@nicolay-r
#223 done.
a38c182
nicolay-r added a commit that referenced this issue Jan 10, 2022
@nicolay-r
#223 related fix.
3f42bcf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r