Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entity_to_group_func -- BaseExperiment should not provide this method. #235

Closed
nicolay-r opened this issue Dec 18, 2021 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

It is expected that entities will be grouped by BasePairProvider, once document will be parsed.
The latter allows us to assign group indices for entities and utilize such information later on, instead of entity_to_group_func

@nicolay-r nicolay-r added the enhancement New feature or request label Dec 18, 2021
@nicolay-r nicolay-r self-assigned this Dec 18, 2021
@nicolay-r
Copy link
Owner Author

Скорее всего такую ф-цию придется добавлять в ParsedNews, так как это основное место где используются экземпляры сущностей, и именно у них должны быть назначены группы. (опциально)

@nicolay-r
Copy link
Owner Author

Делаем назначение групп как элемент Pipeline

@nicolay-r nicolay-r added the task label Dec 19, 2021
@nicolay-r
Copy link
Owner Author

Тогда он также исчезнет из OpinionProvider

@nicolay-r nicolay-r changed the title entity_to_group_func -- BaseExperiment should not provide this method. entity_to_group_func -- BaseExperiment should not provide this method. Dec 20, 2021
nicolay-r added a commit that referenced this issue Dec 20, 2021
nicolay-r added a commit that referenced this issue Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request task
Projects
None yet
Development

No branches or pull requests

1 participant