Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFolding -- organize united data folding. #267

Closed
nicolay-r opened this issue Jan 26, 2022 · 1 comment
Closed

DataFolding -- organize united data folding. #267

nicolay-r opened this issue Jan 26, 2022 · 1 comment
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jan 26, 2022 •
edited
Loading

Proceeds #264.

Reason: provides better customization which is not for now depends on the particular experiment and the related DataType assignation.
@nicolay-r nicolay-r added the enhancement New feature or request label Jan 26, 2022
@nicolay-r nicolay-r self-assigned this Jan 26, 2022
nicolay-r added a commit that referenced this issue Jan 26, 2022
@nicolay-r
#267 done
4a3d3a1
@nicolay-r
Copy link
Owner Author

nicolay-r commented Jan 26, 2022 •
edited
Loading

After refactoring it now allows us to combine foldings of different type within a single UnitedFolding instance, for example:

AREkit/arekit/contrib/experiment_rusentrel/factory.py

Lines 73 to 78 in 4a3d3a1

if exp_type == ExperimentTypes.RuSentRelWithRuAttitudes:
rsr = create_rusentrel_experiment_data_folding(folding_type=rusentrel_folding_type,
version=rusentrel_version)
ra = create_ruattitudes_experiment_data_folding(version=ruattitudes_version,
states_count=rsr.StatesCount)
return UnitedFolding(foldings=[rsr, ra])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r