Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntitiesFormatting -- Cancelling entity values masking may result in out of embedding vocabulary exception [ARElight backlog] #308

Closed
nicolay-r opened this issue Mar 31, 2022 · 1 comment
Closed

EntitiesFormatting -- Cancelling entity values masking may result in out of embedding vocabulary exception [ARElight backlog] #308

nicolay-r opened this issue Mar 31, 2022 · 1 comment
Assignees
@nicolay-r
Labels
bug Something isn't working enhancement New feature or request limitation question Further information is requested task

Comments

@nicolay-r
Copy link
Owner

No description provided.

@nicolay-r nicolay-r added enhancement New feature or request question Further information is requested limitation task labels Mar 31, 2022
@nicolay-r nicolay-r self-assigned this Mar 31, 2022
@nicolay-r nicolay-r changed the title EntitiesFormatting -- Rejecting entitiy values from hiding may result in out of embedding vocabulary exception EntitiesFormatting -- Cancelling entity values masking may result in out of embedding vocabulary exception Mar 31, 2022
@nicolay-r nicolay-r changed the title EntitiesFormatting -- Cancelling entity values masking may result in out of embedding vocabulary exception EntitiesFormatting -- Cancelling entity values masking may result in out of embedding vocabulary exception [ARElight backlog[ Mar 31, 2022
@nicolay-r nicolay-r changed the title EntitiesFormatting -- Cancelling entity values masking may result in out of embedding vocabulary exception [ARElight backlog[ EntitiesFormatting -- Cancelling entity values masking may result in out of embedding vocabulary exception [ARElight backlog] Mar 31, 2022
@nicolay-r
Copy link
Owner Author

nicolay-r commented Jun 21, 2022 •
edited
Loading

Possible solution: Adopt create_term_embedding function for entity values.

AREkit/arekit/contrib/networks/core/input/terms_mapping.py

Lines 83 to 84 in 658d487

m_ind = self.__predefined_embedding.try_find_index_by_plain_word(entity_word)
vector = self.__predefined_embedding.get_vector_by_index(m_ind)

Close or same as #335

@nicolay-r nicolay-r added the bug Something isn't working label Jun 22, 2022
nicolay-r added a commit that referenced this issue Jun 22, 2022
@nicolay-r
#335 fixed and #308 . Considering a function which calcuales the vect…
4e799d6 
…or from parts rather than seeking such in an Embedding
@nicolay-r nicolay-r mentioned this issue Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working enhancement New feature or request limitation question Further information is requested task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r