Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SynonymsCollection -- value_to_group_id_func does not support expansion by default. #327

Closed
nicolay-r opened this issue Jun 7, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

It might be better to refactor a default provided by using a separate set of possible grouping providers.

In ARElight, let's say, there is a workaround for a case when expansion is necessary.
https://github.com/nicolay-r/ARElight/blob/702442d162914957b20a4c5804a24714568f9816/arelight/pipelines/serialize_bert.py#L78

The same happen once we declaring a new source, here for example:

value_to_group_id_func=synonyms.get_synonym_group_index),

From the above, it is unclear whether it is allowed an expansion or not.
Hence we may move all of the related implementations into separated file.

@nicolay-r nicolay-r added the enhancement New feature or request label Jun 7, 2022
@nicolay-r nicolay-r self-assigned this Jun 7, 2022
nicolay-r added a commit that referenced this issue Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant