Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExperimentContext -- remove Evaluator from the base class. #349

Closed
3 tasks
nicolay-r opened this issue Jun 28, 2022 · 0 comments
Closed
3 tasks

ExperimentContext -- remove Evaluator from the base class. #349

nicolay-r opened this issue Jun 28, 2022 · 0 comments
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jun 28, 2022 •
edited
Loading

Reason: Evaluator is an optional part of the experiment.

  • remove Evaluator
  • Important: remove exp_ctx then as well.
  • Clarify that it is the document level evaluator

AREkit/arekit/contrib/utils/handlers/eval.py

Lines 59 to 61 in d3460b9

# getting evaluator.
evaluator = self.__exp_ctx.Evaluator
assert(isinstance(evaluator, BaseEvaluator))

@nicolay-r nicolay-r added the enhancement New feature or request label Jun 28, 2022
@nicolay-r nicolay-r self-assigned this Jun 28, 2022
nicolay-r added a commit that referenced this issue Jun 29, 2022
@nicolay-r
#349 removed
ab36b2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r