Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside [Remove DataType dependency, backlog] #354

Closed
nicolay-r opened this issue Jul 1, 2022 · 0 comments
Closed

DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside [Remove DataType dependency, backlog] #354

nicolay-r opened this issue Jul 1, 2022 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request task

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 1, 2022 •
edited
Loading

This is hardcoded to a particular DataType.Train type:

AREkit/arekit/common/opinions/annot/default.py

Lines 38 to 42 in e8c0e9c

opinions = self.__get_doc_etalon_opins_func(parsed_news.RelatedDocID)
annotated_opins_it = self.__annot_algo.iter_opinions(
parsed_news=parsed_news,
existed_opinions=opinions if data_type == DataType.Train else None)

#345 related

Also opinion annotator should not depend on the DataType
@nicolay-r nicolay-r added the enhancement New feature or request label Jul 1, 2022
@nicolay-r nicolay-r self-assigned this Jul 1, 2022
@nicolay-r nicolay-r changed the title DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside Jul 1, 2022
@nicolay-r nicolay-r changed the title DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside [Remove DataType backlog] Jul 7, 2022
@nicolay-r nicolay-r changed the title DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside [Remove DataType backlog] DefaultOpinionAnnotator -- etalon_opinion logic might be moved outside [Remove DataType dependency, backlog] Jul 7, 2022
nicolay-r added a commit that referenced this issue Jul 8, 2022
@nicolay-r
#354 related todo.
cd8275b
nicolay-r added a commit that referenced this issue Jul 9, 2022
@nicolay-r
#354 related refactoring
7b8c675
nicolay-r added a commit that referenced this issue Jul 9, 2022
@nicolay-r
#354 related refactoring. #326 pipeline API affected. experiment_ruse…
a699b52 
…ntrel factory is no longer supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r