Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentOperations -- iter_doc_ids actually wraps the ExperimentContext functionality #367

Closed
2 tasks done
nicolay-r opened this issue Jul 12, 2022 · 0 comments
Closed
2 tasks done

DocumentOperations -- iter_doc_ids actually wraps the ExperimentContext functionality #367

nicolay-r opened this issue Jul 12, 2022 · 0 comments
Assignees
@nicolay-r
Labels
critical enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 12, 2022 •
edited
Loading

Reason to refactor: we do not want to associate DocumentRelation with the particular DataType
How to refactor: provide these IDS from DataFolding straight.

  • DataFolding move outside of the Context
  • Remove exp_ctx

REMOVE THIS METHOD:

AREkit/arekit/common/experiment/api/ops_doc.py

Lines 28 to 38 in 829966d

def iter_doc_ids(self, data_type):
""" Provides a news indices, related to a particular `data_type`
"""
data_types_splits = self._exp_ctx.DataFolding.fold_doc_ids_set()
if data_type not in data_types_splits:
return
yield
for doc_id in data_types_splits[data_type]:
yield doc_id

@nicolay-r nicolay-r added enhancement New feature or request critical labels Jul 12, 2022
@nicolay-r nicolay-r self-assigned this Jul 12, 2022
nicolay-r added a commit that referenced this issue Jul 13, 2022
@nicolay-r
#367 refactoring.
53c3e2b
nicolay-r added a commit that referenced this issue Jul 13, 2022
@nicolay-r
#367 related. Switched to data_folding
b97c109
nicolay-r added a commit that referenced this issue Jul 13, 2022
@nicolay-r
#367 related refactoring
d7b55d4
nicolay-r added a commit that referenced this issue Jul 13, 2022
@nicolay-r
#367 complete.
13a05bf
nicolay-r added a commit that referenced this issue Jul 13, 2022
@nicolay-r
#367 fixed. removed exp_ctx
98c91cd
nicolay-r added a commit that referenced this issue Jul 14, 2022
@nicolay-r
#366 and #367 related API fix: removed non utilized parameter
c497a32
nicolay-r added a commit that referenced this issue Jul 15, 2022
@nicolay-r
API update. (#367)
4f559f8
nicolay-r added a commit that referenced this issue Jul 15, 2022
@nicolay-r
#367 fix
bc9872b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r