Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelIO -- move vocab and embedding related API to EmbeddingIO #382

Closed
4 tasks done
nicolay-r opened this issue Aug 2, 2022 · 0 comments
Closed
4 tasks done

ModelIO -- move vocab and embedding related API to EmbeddingIO #382

nicolay-r opened this issue Aug 2, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Aug 2, 2022

#282 proceeds.
Reason: It allows us reduce dependency from model_io. Model io keeps innformation about the saved state only, not embeddings and vocabularies as it was before.

  • move get_model_embedding_filepath and get_model_vocab_filepath
  • remove exp_ctx dependency from EmbeddingIO. (model_io)
  • remove ExperimentContext since it includes only model_io.
  • remove BaseModelIO then

Here, it shows that we just pass its contents to EmbeddingIO. Nothing special from ModelIO side:

def get_model_embedding_filepath(self):
return self.__embedding_filepath
def get_model_vocab_filepath(self):
return self.__vocab_filepath

@nicolay-r nicolay-r self-assigned this Aug 2, 2022
@nicolay-r nicolay-r added the enhancement New feature or request label Aug 2, 2022
nicolay-r added a commit that referenced this issue Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant