BratSentence -- entities should be initialized via parameter

[nicolay-r]

Issue: API is Bad because it publicly allows to modify (add) the contents of the BratSentences. The latter may lead to unsync code, based on BratSentences instances.

AREkit/arekit/contrib/source/brat/sentence.py

Lines 20 to 26 in 17563d0

	self.__entities = []
	# region public methods
	def add_local_entity(self, entity):
	assert(isinstance(entity, BratEntity))
	self.__entities.append(entity)

• first step: refactor this to list of sentence_entities
  

  AREkit/arekit/contrib/source/brat/sentences_reader.py

  Lines 19 to 23 in 17563d0

  	while s_ind < len(sentences) and e_ind < len(entities):
  	e = entities.get_entity_by_index(e_ind)
  	assert (isinstance(e, BratEntity))
  	s = sentences[s_ind]

• return information in dict in order to initialize sentence instances later
  

  AREkit/arekit/contrib/source/brat/sentences_reader.py

  Line 61 in 17563d0

  def __parse_sentences(input_file, line_handler):

• fix dependencies RuAttitudes dependencies, i.e. sentence instance nested from the BratSentence. RuAttitudes -- extract_text_opinions_linkages utilizes a different approach which is not covered by common impementation. #232
  (Easy, remove inheritance from BratSentence, in order to create these such sentences during News conversion stage)