Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenNREJsonWriter -- df.sort is not an inplace by default #407

Closed
1 task
nicolay-r opened this issue Oct 14, 2022 · 0 comments
Closed
1 task

OpenNREJsonWriter -- df.sort is not an inplace by default #407

nicolay-r opened this issue Oct 14, 2022 · 0 comments
Assignees
@nicolay-r
Labels
bug Something isn't working enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

The problem is that there is no need to perform this operation. This results in nothing.

AREkit/arekit/common/data/input/writers/opennre_json.py

Line 43 in bf01ba7

df.sort_values(by=[const.ID], ascending=True)

  • We may provide order by columns method, where list of columns correspond the order.
@nicolay-r nicolay-r added bug Something isn't working enhancement New feature or request labels Oct 14, 2022
@nicolay-r nicolay-r changed the title OpenNREJsonWriter -- df.sort is not an inplace by default OpenNREJsonWriter -- df.sort is not an inplace by default Oct 14, 2022
nicolay-r added a commit that referenced this issue Oct 18, 2022
@nicolay-r
#407. pandas-based operations were removed.
f90d78c
@nicolay-r nicolay-r self-assigned this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r