Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TsvWriter -- Remove Dataframe dependency #408

Closed
nicolay-r opened this issue Oct 14, 2022 · 1 comment
Closed

TsvWriter -- Remove Dataframe dependency #408

nicolay-r opened this issue Oct 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Oct 14, 2022

Switch to:
https://docs.python.org/3/library/csv.html

df.sort_values(by=[const.ID], ascending=True)
df.to_csv(target,
sep='\t',
encoding='utf-8',
columns=[c for c in df.columns if c != BaseColumnsProvider.ROW_ID],
index=False,
float_format="%.0f",
compression='gzip',
header=self.__write_header)

@nicolay-r nicolay-r added the enhancement New feature or request label Oct 14, 2022
@nicolay-r nicolay-r changed the title TsvWriter -- provide writing based on csv library. TsvWriter -- Remove Dataframe dependency Oct 17, 2022
@nicolay-r
Copy link
Owner Author

nicolay-r commented Oct 17, 2022

I think it is okay to provide csv_df, i.e. pandas based reader/writer, which is expected to be adopted by default in pandas-based storage kernel.

nicolay-r added a commit that referenced this issue Oct 18, 2022
…ns placement. Readers/Writers based on external tools were moved to `contrib` module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant