Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_provide_sentence_terms -- consider s_ind and t_ind as well since they may combined with and modified at the same time [nivts_project backlog] #420

Closed
nicolay-r opened this issue Nov 27, 2022 · 0 comments
Closed

_provide_sentence_terms -- consider s_ind and t_ind as well since they may combined with and modified at the same time [nivts_project backlog] #420

nicolay-r opened this issue Nov 27, 2022 · 0 comments
Assignees
@nicolay-r

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Nov 27, 2022 •
edited
Loading

Quick fix: need to implement function _provide_sentence_terms which includes s_ind and t_ind and returns them as without changes.

AREkit/arekit/common/data/input/providers/rows/samples.py

Lines 84 to 91 in 8f47fcf

sentence_terms = list(self._provide_sentence_terms(parsed_news=parsed_news, sentence_ind=sentence_ind))
self.__text_provider.add_text_in_row(
set_text_func=lambda column, value: __assign_value(column, value),
sentence_terms=sentence_terms,
s_ind=s_ind,
t_ind=t_ind,
expected_label=expected_label)

@nicolay-r nicolay-r self-assigned this Nov 27, 2022
@nicolay-r nicolay-r changed the title _provide_sentence_terms -- consider s_ind and t_ind as well since they may combined with and modified at the same time _provide_sentence_terms -- consider s_ind and t_ind as well since they may combined with and modified at the same time Nov 27, 2022
@nicolay-r nicolay-r changed the title _provide_sentence_terms -- consider s_ind and t_ind as well since they may combined with and modified at the same time _provide_sentence_terms -- consider s_ind and t_ind as well since they may combined with and modified at the same time [nivts_project backlog] Nov 27, 2022
nicolay-r added a commit that referenced this issue Nov 27, 2022
@nicolay-r
#420 related refactoring.
b81bb1f
nicolay-r added a commit that referenced this issue Nov 27, 2022
@nicolay-r
#420 related fix
aa1b403
nicolay-r added a commit that referenced this issue Dec 9, 2022
@nicolay-r
#420 related fix: iterator is not allowed for sentence terms. Using l…
75fcae0 
…ist instead.
nicolay-r added a commit that referenced this issue Feb 16, 2023
@nicolay-r
#420 fixed bug: mistakenly keeping the non changed s_ind and t_ind.
bec9c9e
@nicolay-r nicolay-r mentioned this issue Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r