Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VocabRepositoryUtils -- numpy API considers # by default in vocabulary on load #428

Closed
nicolay-r opened this issue Dec 25, 2022 · 1 comment
Closed

VocabRepositoryUtils -- numpy API considers # by default in vocabulary on load #428

nicolay-r opened this issue Dec 25, 2022 · 1 comment
Assignees
@nicolay-r
Labels
bug Something isn't working critical

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Dec 25, 2022 •
edited
Loading

It is crutial to set comments = None instead of # by default!

vocab = np.loadtxt(source, dtype=str, comments=None)

#429 related
@nicolay-r nicolay-r added bug Something isn't working critical labels Dec 25, 2022
@nicolay-r nicolay-r self-assigned this Dec 25, 2022
@nicolay-r
Copy link
Owner Author

Suppose to be fixed in prior release as well.

nicolay-r added a commit that referenced this issue Jan 3, 2023
@nicolay-r
#428 fixed.
94a5f16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r