Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpinionCollection -- the case of None for opinion results in incomplete initialization #455

Closed
nicolay-r opened this issue May 1, 2023 · 0 comments
Closed

OpinionCollection -- the case of None for opinion results in incomplete initialization #455

nicolay-r opened this issue May 1, 2023 · 0 comments
Assignees
@nicolay-r
Labels
bug Something isn't working enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

AREkit/arekit/common/opinions/collection.py

Lines 33 to 43 in dbe30c5

if opinions is None:
return
for opinion in opinions:
self.__register_opinion(
opinion=opinion,
error_on_existence=error_on_duplicates,
error_on_synonym_end_missed=error_on_synonym_end_missed)
self.__error_on_duplicates = error_on_duplicates
self.__error_on_synonym_end_missed = error_on_synonym_end_missed

@nicolay-r nicolay-r added bug Something isn't working enhancement New feature or request labels May 1, 2023
@nicolay-r nicolay-r self-assigned this May 1, 2023
@nicolay-r nicolay-r changed the title OpinionCollection -- the case of None for opinion results in incomplete initialization OpinionCollection -- the case of None for opinion results in incomplete initialization May 1, 2023
nicolay-r added a commit that referenced this issue May 2, 2023
@nicolay-r
#453, #454, #455 and #456 were fixed
e28f088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r