Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 entity_index_function -- Drop None option support #516

Closed
Tracked by #495
nicolay-r opened this issue Aug 18, 2023 · 0 comments
Closed
Tracked by #495

🔧 entity_index_function -- Drop None option support #516

nicolay-r opened this issue Aug 18, 2023 · 0 comments
Assignees
@nicolay-r
Labels
critical

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Aug 18, 2023 •
edited
Loading

UPD: We drop the related support only for entity service provider

Drop the None support here:

AREkit/arekit/common/docs/parsed/providers/base.py

Line 13 in 34ee2ad

assert(callable(entity_index_func) or entity_index_func is None)

@nicolay-r nicolay-r mentioned this issue Aug 18, 2023
Closed
6 tasks
@nicolay-r nicolay-r self-assigned this Aug 18, 2023
@nicolay-r nicolay-r changed the title 🔧 EntityIndexFunction -- disable None option support 🔧 entity_index_function -- disable None option support Aug 18, 2023
@nicolay-r nicolay-r changed the title 🔧 entity_index_function -- disable None option support 🔧 entity_index_function -- disable None option support Aug 18, 2023
@nicolay-r nicolay-r changed the title 🔧 entity_index_function -- disable None option support 🔧 entity_index_function -- Drop None option support Aug 18, 2023
nicolay-r added a commit that referenced this issue Aug 19, 2023
@nicolay-r
#516 fixed
8c1635d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r