Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No frames in output #50

Closed
nicolay-r opened this issue Jul 21, 2023 · 1 comment
Closed

No frames in output #50

nicolay-r opened this issue Jul 21, 2023 · 1 comment
Assignees
@nicolay-r
Labels
bug Something isn't working

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 21, 2023 •
edited
Loading

This is related to #465 task.
All the writers are fetch columns from the get_columns_list_with_types.
Which is a SampleColumnsProvider at the moment and a default provider.
The latter does not include frames.

For the following scenario:

python3 -m arekit_ss.sample --writer csv --source ruattitudes --sampler nn --src_lang ru --dest_lang ru --docs_limit 10 --text_parser nn --output_dir ./_out/a/ --no-vec

We have an output without annotated frames

sample-train-0.csv
@nicolay-r nicolay-r added the bug Something isn't working label Jul 21, 2023
@nicolay-r nicolay-r self-assigned this Jul 21, 2023
nicolay-r added a commit that referenced this issue Jul 21, 2023
@nicolay-r
#50 fix: provide as force_collect_columns.
19f4899
nicolay-r added a commit that referenced this issue Jul 21, 2023
@nicolay-r
Merge pull request #51 from nicolay-r/0.23.1
76af4c7 
#50 fix: provide as `force_collect_columns`.
@nicolay-r
Copy link
Owner Author

nicolay-r/AREkit#502 fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r