Support nginx-full

[ThomasTr]

I would be super pleased if you could include nginx-full support.

At the moment it looks like you have nginx hardcoded. Maybe you could optionally use nginx-full as well.

Cheers, Thomas

[nicoverbruggen]

Hi Thomas,

Are you using nginx-full with Homebrew via this custom tap? I'm guessing that even if I make this work where I interact with the nginx formula (i.e. restart nginx, etc), it still won't play nice with Laravel Valet... which I have no control over and probably also uses the hardcoded nginx formula.

Can you tell me more about your setup and what your specific use case is? I think the best option right now is to simply register nginx-full in ~/.config/phpmon/config.json... You can create that file and put the following in:

{
    "scan_apps": [],
    "services": ["nginx-full"],
    "presets": [],
    "export": {}
}

After restarting PHP Monitor it should show up in the dropdown menu below the default formulae for easy disabling/enabling.

Cheers!

[ThomasTr]

Hi Nico,

thanks for your quick response. Yes using this tap. My use case is using some additional nginx module for some of my projects such as cache-purge. I only came up with it when I saw that Nginx is displayed with a question mark in the menu.

Valet already supports nginx-full, as you can see here: cli/Valet/Brew.php#L114. Perhaps you can user this code as inspiration detecting nginx / nginx-full.

[nicoverbruggen]

@ThomasTr I didn't bother to check, thanks for confirming Valet already supports it! Yes, in that case I will ensure that PHP Monitor plays nice with nginx-full :)

I'll upload a preview build here for you to test once I've added the functionality. I'll try to have that done by the end of the week, so stay tuned.

[nicoverbruggen]

Hi @ThomasTr, please try this build: phpmon-990.zip

If you have nginx-full installed and it is linked, the nginx-full service will be used throughout the app.

---

Please note that you should make sure that the regular nginx is not running. (If you have both the regular nginx and nginx-full formulae installed, I currently don't handle this particular situation.) In that case, you may want to run:

brew services stop nginx
brew services stop nginx-full
sudo brew services stop nginx

At this point you may attempt to start nginx-full via PHP Monitor's menu (click on the red cross below 'nginx-full'). That should start the service as needed.

If you're having any additional issues or something doesn't seem to be working, let me know!

[ThomasTr]

Hi @nicoverbruggen,

wow, great, I would not have expected so. A separate build especially for me, I'm completely blown away, and then so fast 😃.

Just installed it and it looks very good. Nginx now has its hook and I can also stop/start it (verified with sudo brew services list).

I also only have the nginx-full installed and running, as both in parallel don't make sense anyway.

Perfect, thanks for that.