-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md: Create ConfigOverride.xcconfig by command line #180
Conversation
I recommend adding the BuildTrio.sh instructions below the line that says there is a script available. Copy the code embedded here into the Trio README: https://github.com/loopandlearn/lnl-scripts/tree/main?tab=readme-ov-file#scripts-for-the-trio-app Code inspection OK of what you added looks good but I can’t test it right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to add the build script that Marion mentioned? If you’d prefer that left for a different PR, then LGTM.
We can fit that in here if someone has a chance to push it now, otherwise merge as is. |
Looks great! |
I reviewed the entire README file after the last commit/ Look for TODO:
Tests:
|
Docs, FAX, Oref0
I added a link for Docs (and links to FAX and Oref0), but should probably wait to add the website ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: when you list it like so (as it is in the current proposal):
git clone --branch=<branch> --recurse-submodules https://github.com/nightscout/Trio.git
cd Trio
Then if the default shell is still set to bash, copy/pasting it to Terminal will automatically execute the first command; which will fail because of the <branch>. This will thus result in an error such as:
"bash: branch: No such file or directory"
I'd suggest writing it as follows, so that when copy/pasting directly to Terminal the user will - regardless of which shell they're using - always have an opportunity to change the <branch> portion before execution (and it auto-terminates if the git command fails for whatever reason; preventing an error for cd on such an occasion):
git clone --branch=<branch> --recurse-submodules https://github.com/nightscout/Trio.git && cd Trio
Thanks for the suggestion. 2-line in zsh: success I'll commit that now with you as the author |
both single and double line versions worked in zsh, but only the single line version worked in bash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
No description provided.