Added --standalone flag #27
Conversation
There was a problem hiding this comment.
The changes looks good.
I think we don't need to ask the browser question as well when doing --standalone setup as we don't really install the latest version Chrome browser on the emulator and asking to install Firefox is also unnecessary for --standalone usage.
We can instead mention it separately that if they want to install the latest version of Firefox as well with --standalone, use the --browser firefox flag.
itsspriyansh
force-pushed
the
standalone
branch
from
f06a9be
to
ae85e44
Compare
|
@garg3133 By browser question, are you referring to the prompt that asks this following question:
Should we remove this entirely in standalone mode? |
|
@itsspriyansh Yeah, and that can be done pretty easily. You just need to set the property meant for the answer to browser question beforehand and that question will be automatically skipped. |
|
@garg3133 I have made the suggested change. |
|
@garg3133 I have added the browser condition. |
itsspriyansh
force-pushed
the
standalone
branch
2 times, most recently
from
2549f34
to
2d4a551
Compare
|
@garg3133 I haved made the suggested change and also added a test. |
itsspriyansh
force-pushed
the
standalone
branch
2 times, most recently
from
97dacf4
to
c0ee1a9
Compare
itsspriyansh
force-pushed
the
standalone
branch
from
c0ee1a9
to
83b0143
Compare
|
@garg3133 Resolved everything. |
itsspriyansh
force-pushed
the
standalone
branch
from
83b0143
to
b492b71
Compare
|
@garg3133 I haved added the test and modified the conditional statements. |
|
Merged, thanks @itsspriyansh! |
|
@itsspriyansh There are still some comments that we shouldn't have for the standalone usage, can you fix them as well? 
|
|
@garg3133 Thanks for the merge! And yes, I will raise a PR removing those comments. |
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
--standaloneflag is added to make sure the tool downloads Android SDK to set up emulator. This will ensure that anything related to nightwatch or testing will not be downloaded.