Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "id" in request body for jsonwire element commands #2122

Merged
merged 3 commits into from
Jun 10, 2019
Merged

Add "id" in request body for jsonwire element commands #2122

merged 3 commits into from
Jun 10, 2019

Conversation

ajpetersons
Copy link
Contributor

Since chromedriver 75 release, tests have become unstable. Namely - chromedriver 75 has enabled w3c mode by default, and that very much contradicts the way how Nightwatch works together with Selenium grid. This can be solved by adding w3c: false to chrome options, but that does not fully work as chromedriver expects "id" in request body, not in path. This might be related to a bugfix in chromedriver, although I am not sure.

This PR adds the "id" parameters in the request body to element related requests. This likely also fixes #2118.

@vlad-vinogradov
Copy link

... This can be solved by adding w3c: false to chrome options, but that does not fully work as chromedriver expects "id" in request body, not in path.

Are you sure that chromedriver expects the "id" in the body but not just some JSON?

See chromedriver bug and discussion in the #2118.

Please try #2118 solution.

@ajpetersons
Copy link
Contributor Author

I've tested the solution in #2118 and it seems to be working for me. Initially, I thought that this should be enough, but for some reason it did not initially work for me. I'll update the files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocol error while running .isElementDisplayed() with chrome 75 on W3C mode
3 participants