Nightwatch Inspector - Blocking parallelism for default case for chrome in debug mode #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
harshit-bs
commented
Apr 12, 2023
harshit-bs
commented
- Fix nightwatch-inspector CRX_HEADER_INVALID #3676
gravityvi
requested changes
Apr 18, 2023
|
@harshit-bs any update on this? |
|
@gravityvi made code changes to disabled parallelism whenever debug flag is passed. I think there is no point in running in parallel while debug flag is passed. Can you review once more? |
swrdfish
approved these changes
May 3, 2023
vaibhavsingh97
approved these changes
May 4, 2023
swrdfish
reviewed
May 4, 2023
beatfactor
reviewed
May 4, 2023
beatfactor
approved these changes
May 4, 2023
Co-authored-by: Andrei Rusu <beatfactor@users.noreply.github.com>
gravityvi
requested changes
May 4, 2023
gravityvi
reviewed
May 5, 2023
gravityvi
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.