Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Nightwatch using TypeScript. #3774

Merged
merged 10 commits into from
Jul 5, 2023
Merged

Build Nightwatch using TypeScript. #3774

merged 10 commits into from
Jul 5, 2023

Conversation

garg3133
Copy link
Member

@garg3133 garg3133 commented Jun 19, 2023

TODO:

  • Copy non .ts/.js files to 'dist` after the build step.
  • Fix failing tests.
  • Test deploy the project and try it out on real projects.

After this change:

To use Nightwatch in dev, run:

npm run dev -- examples/tests/ecosia.js --env chrome

To run a specific Nightwatch unit test:

npm run mocha -- test/src/api/commands/client/testWaitUntil.js

@github-actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@garg3133 garg3133 marked this pull request as ready for review June 19, 2023 13:15
@garg3133
Copy link
Member Author

I tried removing lib and then running tests locally, and all tests are passing. Hence, test runs are independent of lib now, and only depend on files present in dist.

Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR and it looks good overall. I have added a few comments for your consideration.

lib/api/_loaders/command.js Outdated Show resolved Hide resolved
lib/api/_loaders/command.js Outdated Show resolved Hide resolved
bin/nightwatch Outdated Show resolved Hide resolved
bin/runner.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
package.json Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
package.json Show resolved Hide resolved
test/src/analytics/testAnalytics.js Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
@beatfactor
Copy link
Member

can we use ts-node with swc on dev? tsc is going to be very slow and annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants