Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing isEnabled command to new Element API #4033

Closed
wants to merge 3 commits into from

Conversation

subhajit20
Copy link
Contributor

@subhajit20 subhajit20 commented Feb 22, 2024

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master issue/4032
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

issue - #4032

@CLAassistant
Copy link

CLAassistant commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

@garg3133
Copy link
Member

Hi, I said that the content of the file would be similar to the other get* commands, but not exactly the same. You still need to make the required changes to the file to get the isEnabled() functionality working.

@subhajit20
Copy link
Contributor Author

Hey @garg3133 , can you tell me where I have to make changes?

Copy link

github-actions bot commented Feb 22, 2024

Status

  • ✅ Type files updated!

@garg3133
Copy link
Member

@subhajit20 Were you able to get the command working in your sample test?

Overall the code looks good to me, you just need to modify the JSDoc, add test for the command and add type definitions.

For writing test, you can check how the tests are written for get* commands in test/src/api/commands/web-element directory, and the types are to be added in web-element.d.ts file.

@subhajit20
Copy link
Contributor Author

@subhajit20 Were you able to get the command working in your sample test?

Overall the code looks good to me, you just need to modify the JSDoc, add test for the command and add type definitions.

For writing test, you can check how the tests are written for get* commands in test/src/api/commands/web-element directory, and the types are to be added in web-element.d.ts file.

Okay I will do that.
Thanks!!

@subhajit20
Copy link
Contributor Author

Hey @garg3133 , done certain changes.
Let me know if further changes are needed.

@subhajit20 subhajit20 changed the title Add missing isEnabled command to new Element API Add missing isEnabled command to new Element API Feb 22, 2024
@garg3133
Copy link
Member

garg3133 commented Feb 22, 2024

@subhajit20 Mostly same review comments for this PR as well as made in #4039.

@subhajit20 subhajit20 closed this Feb 23, 2024
@subhajit20 subhajit20 deleted the issue/4032 branch February 23, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants