-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing isEnabled
command to new Element API
#4033
Conversation
Hi, I said that the content of the file would be similar to the other |
Hey @garg3133 , can you tell me where I have to make changes? |
Status
|
@subhajit20 Were you able to get the command working in your sample test? Overall the code looks good to me, you just need to modify the JSDoc, add test for the command and add type definitions. For writing test, you can check how the tests are written for |
Okay I will do that. |
Hey @garg3133 , done certain changes. |
705b002
to
0d95b73
Compare
isEnabled
command to new Element API
@subhajit20 Mostly same review comments for this PR as well as made in #4039. |
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
issue - #4032