-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: added .css()
and .getCssValue()
as an alias for .getCssProperty()
#4168
Feat: added .css()
and .getCssValue()
as an alias for .getCssProperty()
#4168
Conversation
Done all the required changes for this Pr as Well |
.css()
and .cssValue()
as an alias for .getCssProperty()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the merge conflict in this PR.
|
||
// Extra tests | ||
it('test browser.element().css()', async function () { | ||
|
||
|
||
const resultPromise = this.client.api.element('#signupSection').css('height'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move these test cases to their respective places. And if you see clearly, the test case for .css()
is already present in the file.
.css()
and .cssValue()
as an alias for .getCssProperty()
.css()
and .getCssValue()
as an alias for .getCssProperty()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Thankyou. |
…4168) Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
fixes #4167
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
examples/tests
directory of the project) and running them.ecosia.js
andduckDuckGo.js
are good examples to work with.features/my-new-feature
orissue/123-my-bugfix
);