[PHP 8.1] Add Enums

[TomasVotruba]

Closes #757

enum Suit {
  case Hearts;
  case Diamonds;
  case Clubs;
  case Spades;
}

[szepeviktor]

[WIP] is really a Draft PR on GitHub :)

[TomasVotruba]

I know, thanks :) I've seen more people forgot to switch that than to make it useful.
This is rather comment for me to keep me going :D

[TomasVotruba]

@nikic Hi, I made first draft, but got stuck on unclear error probably related to enum name grammar. I'm lost about why enum is not taken as keyword.

Could you review the PR so far? Thank you

[szepeviktor]

Hi, I made first draft, but got stuck on

Hi, I made first [WIP], but got stuck on ... 😃

[TomasVotruba]

@nikic Hi, since Enums are now accepted and merged in PHP core, could you give me feedback on this?
Thank you 👍

[nikic]

Can you please rebase over a8223f2? The enum keyword needs slightly special handling.

[TomasVotruba]

Thanks! I've rebased and grammar works perfectly 👍

I'm adding more tests case and there is weird one, where string is not interpreted as Identifier, but as Name. I have tried to run test update, but it didn't change anything:

php test/updateTests.php

Any how to fix it?

Otherwise it's ready to review

[nikic]

@TomasVotruba Possibly this is because you added enums to the PHP 5 grammar as well, where string is a class type? I would suggest to drop them from php5.y and mark tests as !!php7.

[TomasVotruba]

I've removed enum from php5.y grammer and it looks good 👍

[TomasVotruba]

Ready to review ✔️

[TomasVotruba]

I've processed your comments and CI is passing with both format preserving and normal tests 👍
Let me know if there is something missing, so I can finish it.

[TomasVotruba]

Thanks 🥳