Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish package on Packagist / Composer #29

Open
msjyoo opened this issue Jun 8, 2016 · 7 comments
Open

Publish package on Packagist / Composer #29

msjyoo opened this issue Jun 8, 2016 · 7 comments

Comments

@msjyoo
Copy link

msjyoo commented Jun 8, 2016

Hello,

I think it will be a good idea to publish this package on Packagist, for the PHP stub?

@mallardduck
Copy link

I'd like to bump this and even suggest that maybe PECL would be a good option. I 100% support the efforts of #5 but until that gets more traction this should be pursued. That's just my opinion, but I think there's a huge benefit to having easier access to this extension.

With testing environments like gitlabci, travis and etc PECL would make this a lot easier to run automated tests with tools required ext-ast. If distributing that with composer is an option as well then I would support that one too! Looking forward to any info on this or any updates.

I'd be happy to assist with getting this into Composer or PECL if that would make it easier to get this moving!

TysonAndre added a commit to TysonAndre/php-ast that referenced this issue Jun 10, 2017
Verified that `pecl package; pecl install ast-0.1.5dev.tgz` worked in
php 7.1.

For Issue nikic#29 (Having a package.xml reduces the work to submit this to PECL)
TysonAndre added a commit to TysonAndre/php-ast that referenced this issue Jun 10, 2017
Verified that `pecl package; pecl install ast-0.1.5dev.tgz` worked in
php 7.1.

For Issue nikic#29 (Having a package.xml reduces the work to submit this to PECL)
nikic pushed a commit that referenced this issue Jun 24, 2017
Verified that `pecl package; pecl install ast-0.1.5dev.tgz` worked in
php 7.1.

For Issue #29 (Having a package.xml reduces the work to submit this to PECL)
@AnrDaemon
Copy link

It's on PECL now.
Perhaps, this isue can be closed?

@drupol
Copy link

drupol commented Mar 8, 2020

IMHO, this is not a PHP package per se and it shouldn't be published on packagist.

@mallardduck
Copy link

@drupol I think the intent of this was to have easier access - per my comment PECL made more sense though. Now that' it's on PECL this could probably be closed for either: a) being fulfilled, or b) for not being the proper route.

@drupol
Copy link

drupol commented Mar 8, 2020

All good then, @nikic I think you can close this one.

@nikic
Copy link
Owner

nikic commented Mar 11, 2020

I believe the idea is to publish it on composer for the utility functions in https://github.com/nikic/php-ast/blob/master/util.php and the stubs in https://github.com/nikic/php-ast/blob/master/ast_stub.php. Though for the latter, it might make more sense to add this extension to https://github.com/JetBrains/phpstorm-stubs, which is whether most tooling sources their stubs from.

@TysonAndre
Copy link
Collaborator

TysonAndre commented Mar 11, 2020

@nikic https://github.com/phan/phan/blob/2.6.0/src/Phan/Language/Internal/ConstantDocumentationMap.php#L80 has some stub descriptions already written for the constants declared for php-ast, if you were interested. (this repo has its own descriptions for methods already)

Those were written for Phan's use case (knowing which properties existed in $node->children, from an editor or IDE, in Phan's language server), but may be useful there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants