Skip to content

Conversation

TesseractA
Copy link
Contributor

As the title comments; hopefully I've not neglected anything that has "Stockfish 10" in it.

that's pretty much it; change the name of stockfish 10 to stockfish-11.
accordig -> according
Seems the authors decided to change file syntax; looks like they put in a date in place of where stockfish 11 was supposed to be.
@TesseractA
Copy link
Contributor Author

Fixes #541 and my conscience about spelling errors

@niklasf
Copy link
Owner

niklasf commented Apr 29, 2020

Thanks. Can you please update Stockfish .travis.yml as well, to match the Windows build?

@PedanticHacker
Copy link
Contributor

I think it doesn't hurt if we use stockfish_20011801_x64_bmi2.exe. The BMI2 version is much much faster. Intel processors since 2013 (basically from the Haswell processor design onwards) all use this new instruction set. The BMI2 instruction set (i.e., the pext and pdep instructions) makes it possible to speed up Stockfish calculations quite a bit, actually.

@TesseractA
Copy link
Contributor Author

@PedanticHacker How about AMD processors? (Also, my desktop is a 2011 computer, yes outdated, but probably cannot run bmi2)

@TesseractA
Copy link
Contributor Author

TesseractA commented Apr 29, 2020

Well I'm not installing stockfish with pychess anytime soon (so I don't need my desktop to run this one.) But from my perspective it looks like this one is done.

@niklasf niklasf merged commit 24a7c8a into niklasf:master Apr 29, 2020
@niklasf
Copy link
Owner

niklasf commented Apr 29, 2020

Thanks!

This is just the automated test suite, so performance doesn't really matter. Both modern or bmi2 are fine, if the testing infrastructure supports it.

@brianprichardson
Copy link

If including SF here then certainly the lowest common denominator version should be used. Many have PCs without BMI2 support (some even without popcnt). Python-chess should not be triggering problems with SF which is not part of this repo, IMHO. If you want to leave it as is fine. If it triggers a bunch of "python-chess does not work for me anymore" issues it is easy to see if this is the cause and revert at that point.

@TesseractA
Copy link
Contributor Author

Well, what we could do is test whether stockfish installs and runs. If not, then we can create an assert that causes us to install another version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants