-
Notifications
You must be signed in to change notification settings - Fork 293
Create tasks.json #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tasks.json #170
Conversation
Enables Visual Studio code integration with Waf for configure and build.
.vscode/tasks.json
Outdated
"label": "Configure Waf for host OS: x86", | ||
"type": "shell", | ||
"problemMatcher": [], | ||
"command": "./waf configure -T release --prefix=out/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On macOS you need to call python3 waf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire configuration is made on the assumption that macOS is still not supported, as per the Wiki.
Is the wiki wrong? Is macOS now supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS is supported. wiki is not updated yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On that note, is newer Android NDK supported? And what command would you run to configure for it? Does it work on Windows now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still like to know if building for Android on Windows is supported, although I have gone ahead and assumed it is, in a recent commit.
Addresses some comments by @exstrim401. These changes were made through GitHub's editor, they have not been tested.
Adds macOS-specific commands
Adding commands for Android build on Windows and macOS just in case it's now supported. This will just result in an error if it's not supported anyway.
Add out folder to gitignore or change it to build/out |
Thought I already did this
f98db24
to
a15db00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergeplsnthx |
a65e792
to
92028d4
Compare
Enables Visual Studio Code integration with Waf for configure and build.