Skip to content

Conversation

halotroop2288
Copy link
Contributor

@halotroop2288 halotroop2288 commented Jan 9, 2023

Enables Visual Studio Code integration with Waf for configure and build.

Enables Visual Studio code integration with Waf for configure and build.
"label": "Configure Waf for host OS: x86",
"type": "shell",
"problemMatcher": [],
"command": "./waf configure -T release --prefix=out/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On macOS you need to call python3 waf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire configuration is made on the assumption that macOS is still not supported, as per the Wiki.
Is the wiki wrong? Is macOS now supported?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS is supported. wiki is not updated yet

Copy link
Contributor Author

@halotroop2288 halotroop2288 Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On that note, is newer Android NDK supported? And what command would you run to configure for it? Does it work on Windows now?

Copy link
Contributor Author

@halotroop2288 halotroop2288 Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to know if building for Android on Windows is supported, although I have gone ahead and assumed it is, in a recent commit.

Addresses some comments by @exstrim401.
These changes were made through GitHub's editor, they have not been tested.
Adds macOS-specific commands
Adding commands for Android build on Windows and macOS just in case it's now supported. This will just result in an error if it's not supported anyway.
@exstrim401
Copy link
Contributor

Add out folder to gitignore or change it to build/out

@halotroop2288
Copy link
Contributor Author

halotroop2288 commented Jan 13, 2023

Add out folder to gitignore or change it to build/out

I intended to fix this in #171 with bab3ccc but on the assumption this is more likely to be merged, I'll just do that here, and rebase that PR later.
Again, this mistake was made, taking the wiki as gospel.

Thought I already did this
@nillerusr nillerusr force-pushed the master branch 9 times, most recently from f98db24 to a15db00 Compare January 14, 2023 12:54
Copy link
Contributor

@exstrim401 exstrim401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halotroop2288
Copy link
Contributor Author

mergeplsnthx

@nillerusr nillerusr force-pushed the master branch 18 times, most recently from a65e792 to 92028d4 Compare April 7, 2023 12:00
@nillerusr nillerusr merged commit 231c1e1 into nillerusr:master Apr 24, 2023
@halotroop2288 halotroop2288 deleted the patch-1 branch April 24, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants