Skip to content

Conversation

matkuki
Copy link
Contributor

@matkuki matkuki commented Mar 8, 2016

  • update the type naming convention and also added the 'deprecate' pragmas for all old type names
  • added a couple of missing procedures needed by the examples
  • new examples, deleted the old ones
  • renamed .babel to .nimble file

Everything was tested and working on windows. Feedback from other platforms would be much appreciated.

I have the wrapper for Python 3 ready and waiting, I was thinking it would be better to add it as a separate library. Do you agree?

Matic

@Araq
Copy link
Member

Araq commented Mar 9, 2016

I have the wrapper for Python 3 ready and waiting, I was thinking it would be better to add it as a separate library. Do you agree?

I guess that makes sense.

@Araq
Copy link
Member

Araq commented Mar 9, 2016

If you change that much, please make it adhere to NEP-1 (our style guide) rather than what the Python C programmers considered good style (which is ugly).

@matkuki
Copy link
Contributor Author

matkuki commented Mar 9, 2016

Are you sure, Araq?
Porting from C (manuals, tutorials, examples,...) will then become less trivial if function/constant/variable names change.

@Araq
Copy link
Member

Araq commented Mar 9, 2016

That's what we usually try to do for new wrappers.

@matkuki
Copy link
Contributor Author

matkuki commented Mar 10, 2016

@Araq
Updated to NEP-1 guidelines. Please review.

[Package]
name: "python"
version: "1.1"
author: "Andreas Rumpf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace mine name with yours or add yours. Give yourself some credit!

@matkuki
Copy link
Contributor Author

matkuki commented Mar 12, 2016

@Araq
Thanks. Also updated the version number.



## Very high level python binding examples
proc Example1() =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Procedures shouldn't start with uppercase letters.

@dom96
Copy link
Contributor

dom96 commented Mar 17, 2016

stmt (and expr) is a special type, defining an enum value by that name may cause issues: https://github.com/matkuki/python/blob/master/src/python.nim#L200

@dom96
Copy link
Contributor

dom96 commented Mar 17, 2016

I would also consider removing the py prefixes.

@matkuki
Copy link
Contributor Author

matkuki commented Mar 18, 2016

@dom96
Done, done, done and done! Compiles and works.
Please check.

dom96 added a commit that referenced this pull request Mar 18, 2016
@dom96 dom96 merged commit 6880326 into nim-lang:master Mar 18, 2016
@dom96
Copy link
Contributor

dom96 commented Mar 18, 2016

Looks good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants