Skip to content

fix zrank/zrevrank may return an interger or nil string #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2020
Merged

fix zrank/zrevrank may return an interger or nil string #18

merged 2 commits into from
Mar 27, 2020

Conversation

ba0f3
Copy link
Contributor

@ba0f3 ba0f3 commented Mar 25, 2020

ZRANK/ZREVRANK will return Integer if member exists in sorted set, otherwise they will return a string of nil

@Araq Araq requested a review from dom96 March 26, 2020 00:18
@ba0f3
return redisNil
909c0e2 
make zrank/zrevrank return `redisNil` instead of nil string
dom96
dom96 approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, but I'd like something a bit stricter.

@dom96 dom96 merged commit 8224fb0 into nim-lang:master Mar 27, 2020
@ba0f3 ba0f3 deleted the zrank/zrevrank branch March 28, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ba0f3 @dom96