Move public types into client directory #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraveux
approved these changes
Aug 18, 2020
sisou
force-pushed
the
soeren/public-client-types
branch
from
862c18e
to
45da856
Compare
To avoid requiring main Hub src for building the client.
sisou
force-pushed
the
soeren/public-client-types
branch
from
45da856
to
6c6d90c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing of related branches across Wallet and Hub (as is the case now for the Bitcoin integration) we want to achieve the following goals:
Linking NPM dependencies locally only works in a local dev environment.
Linking to Github branches only works when the package.json of the dependency is in the root directory of the repo (which it is not for the clients).
A promising method seems to be to use https://gitpkg.now.sh/, which can build packages of subdirectories of Github repos - This worked great for the Keyguard Client, which works independently of the rest of the Keyguard code. The Hub Client (HubApi), however, is depending on lib files from the main Hub codebase, and thus cannot be built by gitpkg.
This PR moves all public request types that are used in the Hub Client (HubApi) into the
clientfolder and adjusts the references from other files linking to it. This leaves the main Hub still buildable as usual, but has the added benefit that now gitpkg can build packages for the HubApi of development branches, avoiding unstable NPM releases.