New designs #15
Merged
New designs #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New loading spinner easing
sisou
force-pushed
the
soeren/new-designs
branch
from
53593ee to
f71861f
Compare
danimoh
requested changes
Feb 22, 2019
| }; | ||
| }, | ||
| template: `<LabelInput :value="value" @changed="changed"/>`, | ||
| template: `<LabelInput placeholder="Name this account..." @changed="changed"/>`, |
There was a problem hiding this comment.
Instead of having two LabelInput stories, should be just one that's configurable with a knob
| }, | ||
| template: `<AccountSelector @account-selected="accountSelected" @switch-wallet="switchWallet" :accounts="accounts" :walletId="walletId" :walletLabel | ||
| ="walletLabel" :walletType="walletType"/>` | ||
| template: `<AccountSelector @account-selected="accountSelected" @login="login" :wallets="wallets"/>` |
There was a problem hiding this comment.
maybe add a knob to edit the wallets, for testing how the component behaves with multiple wallets
| <PaymentInfoLine :amount="amount" :fee="fee" :address="shopAddress" :origin="origin" :shopLogoUrl="shopLogoUrl" @merchant-info-clicked="openMerchantInfo"/> | ||
| <h1 style="font-size: 3rem; text-align: center; margin: 3rem 0 1rem; line-height: 1;">Choose an account to pay</h1> | ||
| <AccountSelector @account-selected="accountSelected" @login="login" :wallets="wallets" :minBalance="amount + fee"/> | ||
| <AccountInfo v-if="showMerchantInfo" :address="shopAddress" :origin="origin" :shopLogoUrl="shopLogoUrl" @close="closeMerchantInfo" style="position: absolute; left: 0; top: 0;"/> |
There was a problem hiding this comment.
better to make the other story configurable with knobs or a button in the template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.