Skip to content

Conversation

cl4u2
Copy link
Contributor

@cl4u2 cl4u2 commented May 3, 2015

According to my tests, olsrd's jsoninfo does not work with http (unlike txtinfo), so I here add support for telnet URIs, which are roughly equivalent to plain TCP sockets.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.5%) to 92.59% when pulling 0680e9d on cl4u2:telnet into de625ca on ninuxorg:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 0680e9d on cl4u2:telnet into de625ca on ninuxorg:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.38%) to 92.71% when pulling d0dce62 on cl4u2:telnet into de625ca on ninuxorg:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling d0dce62 on cl4u2:telnet into de625ca on ninuxorg:master.

@nemesifier
Copy link
Member

👍 !

do you think it's worth it to add support for the olsr txtinfo plugin too?

@nemesifier nemesifier merged commit d0dce62 into openwisp:master May 3, 2015
nemesifier added a commit that referenced this pull request May 3, 2015
@cl4u2
Copy link
Contributor Author

cl4u2 commented May 3, 2015

txtinfo support might be useful, as it is more popular than the jsoninfo, but probably is not worth the effort at this stage

@nemesifier
Copy link
Member

@cl4u2 I'm thinking about it because it might be the only way to facilitate the migration from the old nodeshot to the new one, think about asking all the ninux gorups to update their topologies to JSON.. it may take months.. lol

@cl4u2
Copy link
Contributor Author

cl4u2 commented May 3, 2015

A library to convert txtinfo format to JSON may be useful also for other projects

@nemesifier
Copy link
Member

Maybe some of this code can be adapted and reused:
https://github.com/ninuxorg/nodeshot/blob/0.9.x/nodeshot/scripts/read_topology_hna.py#L62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants