Improvement and tests for olsrd1parser #2
Conversation
|
build is failing, checkout why: "TabError: inconsistent use of tabs and spaces in indentation" |
|
on python3 mixing tabs and spaces its not allowed, enable whitespace characters in your editor so you can spot tabs (marked usually as arrows). |
|
seems to me it doesn't work anyway. you are missing the nodes/edges that are in the new graph but not in the old one. You have to add them back in the diff. |
|
@leonardomaccari I solve that problem doing the differerence on the two combinations of the graphs. One result will be the addedd nodes and the other the removed nodes. The real problem was that the old function were removing nodes that were in both graph, but we're interested in removing edges, not nodes! |
removed old code, now test works!!!! corrected bug for py3 maybe this time will work Corrected the difference function, now it return the difference between the edges of 2 graph. Made a new test for the parser. Fixed weight in json generation.
I've corrected the diff function. the networkx.difference function is not usable to make the diff beetween two graph with different node sets. I've implemented the difference between to graph, removing the node that are in graph a from graph b.
I've created a Subgraph generator using the @leonardomaccari function.
With this function i've built a test for olsr1parser