Skip to content

Improved OpenVPN parser #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2017
Merged

Improved OpenVPN parser #47

merged 2 commits into from
Sep 25, 2017

Conversation

nemesifier
Copy link
Member

@rohithasrk: check my improvements in 4ebfb69

@coveralls
Copy link

coveralls commented Sep 22, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4ebfb69 on openvpn into 90e5eac on master.

rohithasrk
rohithasrk approved these changes Sep 24, 2017
View reviewed changes
Copy link
Contributor

@rohithasrk rohithasrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great @nemesisdesign. You made it a lot easier 😄

@nemesifier
Copy link
Member Author

thx @rohithasrk, I'll merge now.

@nemesifier nemesifier merged commit 40071b0 into master Sep 25, 2017
This was referenced Sep 25, 2017
Closed
Closed
@nemesifier nemesifier deleted the openvpn branch January 15, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rohithasrk rohithasrk rohithasrk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nemesifier @coveralls @rohithasrk