Skip to content

Conversation

AYZhu
Copy link
Contributor

@AYZhu AYZhu commented Nov 30, 2017

This ensures that we test for pep8 compliance during Travis instead of self-enforcing.

@coveralls
Copy link

coveralls commented Nov 30, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling fd1479c on AZtheAsian:master into 71ff3b7 on ninuxorg:master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AZtheAsian welcome! Thanks for taking this, you are almost there, please read my inline comment.

.travis.yml Outdated
- pip install -r requirements-test.txt

# command to run flake8
before_script: "flake8 --ignore=E501,W291,W293 netdiff"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs improvement, please proceed as follows:

  1. set the line length to 110 characters in a similar fashion this example setup.cfg file (it means adding a flake8 section and a max-line-length = 110 line
  2. remove the --ignore flag entirely
  3. fix any issue that comes up

Copy link
Contributor

@rohithasrk rohithasrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AZtheAsian Also squash all the commits into and change the commit message to something like [QA] Added flake8 check to Travis tests. QA means Quality Assurance and also notice that we've used past tense in the commit messages. Good job btw!

@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 0861e2e on AZtheAsian:master into 71ff3b7 on ninuxorg:master.

@coveralls
Copy link

coveralls commented Dec 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 48cfbba on AZtheAsian:master into 71ff3b7 on ninuxorg:master.

universal=1

[flake8]
max-line-length = 110
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need a newline at line number 5

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AZtheAsian sorry for the wait, @auvipy is right regarding the new line comment, please pay attention to comments from other mentors too next time, for this time I'll take care of adding the newline.

@nemesifier nemesifier merged commit 48cfbba into openwisp:master Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants