[MAINT] refactor pipeline steps. #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathdugre
force-pushed
the
ref/pydantic-schema
branch
from
1538f80 to
110ff17
Compare
BIDS and Preprocessing pipeline classes now handle the step validation, making the JSON schema less confusing in the docs.
mathdugre
force-pushed
the
ref/pydantic-schema
branch
from
110ff17 to
29ee6e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
michellewang
reviewed
Nov 1, 2024
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| from abc import ABC | |||
| from pathlib import Path | |||
| from typing import Any, Optional, Type, Union | |||
| from typing import Any, Optional, Union | |||
There was a problem hiding this comment.
I think if you use from __future__ import annotations then you would be able to use the | operator instead of Union 🍒
michellewang
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIDS and Preprocessing pipeline classes now handle the step validation, making the JSON schema less confusing in the docs.
Changes proposed in this pull request:
Checklist (for reviewers)
This section is for the PR reviewer
[BUG],[DOC],[ENH],[MAINT])Refer to NumPy Development Guide for a full list
Closes #XXXXFor new features:
For bug fixes: