Enhance security and safeguard for Zenodo uploads. #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ No longer read password from cli or env var.
9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
michellewang
requested changes
May 6, 2025
| sandbox=params.pop("sandbox"), | ||
| access_token=params.pop("access_token"), | ||
| ) | ||
| with handle_exception(PipelineSearchWorkflow(**params)) as workflow: |
There was a problem hiding this comment.
Can we have the Zenodo-related workflows accept sandbox and password_file directly (instead of the Zenodo API)? So that the CLI command does exactly the same thing as the workflow class
michellewang
reviewed
May 6, 2025
michellewang
approved these changes
May 6, 2025
michellewang
approved these changes
May 6, 2025
Comment on lines
+88
to
+90
| if not continue_: | ||
| self.logger.info("Zenodo upload cancelled.") | ||
| raise SystemExit(1) |
There was a problem hiding this comment.
🍒 we could mock this to get 100% test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Checklist (for reviewers)
This section is for the PR reviewer
[BUG],[DOC],[ENH],[MAINT])Refer to NumPy Development Guide for a full list
Closes #XXXXFor new features:
For bug fixes:
📚 Documentation preview 📚: https://nipoppy--626.org.readthedocs.build/en/626/