Skip to content

Conversation

michellewang
Copy link
Collaborator

@michellewang michellewang commented May 6, 2025

  • Closes none

Changes proposed in this pull request:

  • This PR reverts a change in [ENH] Make HPC_CONFIG_FILE use a relative path #622 where substitutions were applied to invocations immediately on load. It turns out this causes some problems (and warnings) since invocations require on-the-fly substitutions related to participant/session IDs

Checklist (for reviewers)

This section is for the PR reviewer

  • PR has an interpretable title with a prefix (e.g. [BUG], [DOC], [ENH], [MAINT])
    Refer to NumPy Development Guide for a full list
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions

📚 Documentation preview 📚: https://nipoppy--627.org.readthedocs.build/en/627/

@michellewang michellewang requested a review from mathdugre May 6, 2025 20:52
@github-actions github-actions bot added the T.0 - Bug Something isn't working label May 6, 2025
@nipoppy-bot nipoppy-bot bot added this to Software May 6, 2025
@nipoppy-bot nipoppy-bot bot moved this to Pending review in Software May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
nipoppy/workflows/pipeline.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@mathdugre mathdugre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@github-project-automation github-project-automation bot moved this from Pending review to Approved in Software May 9, 2025
@michellewang michellewang merged commit 7dcb34f into nipoppy:main May 9, 2025
10 checks passed
@michellewang michellewang deleted the bug/invocation_substitutions branch May 9, 2025 16:47
@nipoppy-bot nipoppy-bot bot moved this from Approved to Done in Software May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T.0 - Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants