Skip to content

Conversation

mathdugre
Copy link
Collaborator

@mathdugre mathdugre commented Jul 23, 2025

Changes proposed in this pull request:

Checklist (for reviewers)

This section is for the PR reviewer

  • PR has an interpretable title with a prefix (e.g. [BUG], [DOC], [ENH], [MAINT])
    Refer to NumPy Development Guide for a full list
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions

📚 Documentation preview 📚: https://nipoppy--698.org.readthedocs.build/en/698/

@mathdugre mathdugre requested a review from michellewang July 23, 2025 18:58
@nipoppy-bot nipoppy-bot bot added this to Software Jul 23, 2025
@nipoppy-bot nipoppy-bot bot moved this to Pending review in Software Jul 23, 2025
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
nipoppy/cli.py 100.00% <100.00%> (ø)
nipoppy/workflows/pipeline_store/upload.py 100.00% <ø> (ø)
nipoppy/zenodo_api.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@michellewang michellewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should shorten the names of the test files? E.g. test_config_boutiques.py -> test_boutiques.py since it will be in the config directory anyway?

@mathdugre mathdugre requested a review from michellewang July 24, 2025 21:04
@mathdugre mathdugre force-pushed the maint/reorg-tests branch from 2708535 to 6b87f0d Compare July 24, 2025 21:24
@github-project-automation github-project-automation bot moved this from Pending review to Reviewed in Software Jul 25, 2025
mathdugre and others added 3 commits July 29, 2025 10:28
@mathdugre mathdugre requested a review from michellewang July 29, 2025 15:19
@nipoppy-bot nipoppy-bot bot moved this from Reviewed to Pending review in Software Jul 29, 2025
@github-project-automation github-project-automation bot moved this from Pending review to Reviewed in Software Jul 29, 2025
Copy link
Collaborator

@michellewang michellewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@github-project-automation github-project-automation bot moved this from Reviewed to Approved in Software Jul 29, 2025
@michellewang michellewang merged commit 337c152 into nipoppy:main Jul 29, 2025
9 checks passed
@nipoppy-bot nipoppy-bot bot moved this from Approved to Done in Software Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[MAINT] Organize test in subfolders instead of flat list
2 participants