Skip to content

Conversation

nikhil153
Copy link
Collaborator

No description provided.

@nikhil153 nikhil153 requested a review from michellewang March 17, 2023 22:45
Copy link
Collaborator

@michellewang michellewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We could also add what we wrote in #61 to the README so all the information is in the same place (and we could close the issue after).

### GH workflow for contributing to template and dataset-specific forks

![mr_proc_gh_contribution_workflow](https://user-images.githubusercontent.com/7978607/226065220-c1123b5e-8774-4f02-b8ef-0f2255cdf122.jpg)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the direction of the arrow mr_proc-[dataset] <-> mr_proc-() ok ? are you not pushing the merged feature on mr_proc-[dataset] to mr_proc-() ? (at the moment, arrow seems to indicate you will push from mr_proc-(*) to mr_proc-[dataset] )

Copy link
Collaborator Author

@nikhil153 nikhil153 Mar 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nothing should be pushed from mr_proc-[dataset] to mr_proc(*). Updates to mr_proc(*) will come from the user-GH fork PRs only and then distributed to all the datasets by GH-actions. This is to keep "global" changes separate from "dataset-specific" changes.

@nikhil153 nikhil153 merged commit 5f27c8b into nipoppy:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants