ENH: Add single-shell covariance models #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
AddSingleShellCovModels
branch
6 times, most recently
from
e9e4744
to
57f216a
Compare
Add the exponential and spherical covariance models for single-shell dMRI data following Andersson 2015.
jhlegarreta
force-pushed
the
AddSingleShellCovModels
branch
from
57f216a
to
ea0913f
Compare
|
Does this deprecate #201? |
No, PR #201 will cover the multi-shell case, and this functions will be re-used as necessary there. This PR is useful as is for the single-shell case (see https://github.com/nipreps/eddymotion/pull/203/files#r1649732288), and hopefully allows to tell more easily whether up to this functions things provide the expected results. This is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the exponential and spherical covariance models for single-shell dMRI data following Andersson 2015.