Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add dMRI covariance model notebook #214

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

jhlegarreta
Copy link
Collaborator

Add dMRI covariance model notebook.

@jhlegarreta
Copy link
Collaborator Author

jhlegarreta commented Jun 22, 2024

Depends on PR #213.

Am missing something when computing the covariance from the HCP participant data; the scatter data point trend does not look like the figure in the paper.

Add dMRI covariance model notebook.
@jhlegarreta
Copy link
Collaborator Author

In order to go forward and have the notebook minimal contents available, I'm plotting only the covariance method curves for now. Once this gets merged I'll add the observed covariance data part #214 (comment).

@jhlegarreta jhlegarreta marked this pull request as ready for review July 3, 2024 22:53
@jhlegarreta
Copy link
Collaborator Author

@oesteban as discussed this morning, this is ready to be merged. I will add a separate PR once this gets merged to plot the observed covariance from an DWI signal, and will work there to try to solve #214 (comment).

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oesteban oesteban merged commit c1bd3da into nipreps:main Jul 4, 2024
6 checks passed
@jhlegarreta jhlegarreta deleted the AddCovModelNotebook branch July 4, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants