Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: add --fs-subjects-dir usage to slurm example #2003

Merged
merged 3 commits into from
Feb 27, 2020
Merged

DOC: add --fs-subjects-dir usage to slurm example #2003

merged 3 commits into from
Feb 27, 2020

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Feb 26, 2020

Closes #1907

@auto-comment
Copy link

auto-comment bot commented Feb 26, 2020

Thank your for raising your pull request.

Some of the fMRIPRep maintainers will review your changes as soon as time permits.
I'm attaching below a Review Checklist for the reviewers, to check off during the
review.

PR Review

Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide

  • As the reviewer I confirm that there are no conflicts of interest for me to review this work.

Please check what applies in the following aspects of the PR:

Code documentation

  • New functions and modules are documented following the guidelines.
  • Existing code required amendments in documentation and has been updated.
  • Sufficient inline comments ensure readability by other contributors in the long term.

Documentation site

  • The modifications to fMRIPrep in this PR do not require extra documentation. This is a common situation when a bug fix that does not change the code base substantially is submitted.
  • This PR requires documentation. The corresponding documentation will be submitted as an additional PR in the future.
  • This PR requires extra documentation, and will be included within this PR. Please check the boxes that apply best:
    • An existing feature is substantially modified, changing the interface and/or logic of a module.
    • A new feature is being added, therefore full documentation of it will be included
    • This PR addresses an error in existing documentation.
  • Yes, all expected sections of documentation were generated by the CI build, and look as expected

Tests

  • The new functionalities in this PR are covered by the existing tests
  • New test batteries have been included with this PR

Data

  • This PR does not require any additional data to be uploaded to OSF.
  • This PR requires additional data for tests.

Dependencies: smriprep

  • This PR does not require any update on smriprep; or
  • smriprep has correctly been pinned.

Dependencies: niworkflows

  • This PR does not require any update on niworkflows; or
  • niworkflows has correctly been pinned.

Dependencies: sdcflows

  • This PR does not require any update on sdcflows; or
  • sdcflows has correctly been pinned.

Dependencies: Nipype

  • This PR does not require any update on nipype; or
  • nipype has correctly been pinned.

Dependencies: other

  • This PR does not require any update on other dependencies; or
  • other dependencies have correctly been pinned.

Reports generated within CI tests

  • Yes, I have checked the reports of ds005 and they are not modified or the changes are as expected
  • Yes, I have checked the reports of ds054 and they are not modified or the changes are as expected
  • Yes, I have checked the reports of ds010 and they are not modified or the changes are as expected

@mgxd mgxd changed the base branch from master to maint/20.0.x February 26, 2020 18:33
oesteban
oesteban reviewed Feb 26, 2020
View reviewed changes
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really appreciate to see a new Q&A in the docs/faq.rst file about FS derivatives reutilization and this flag before closing #1907

docs/_static/sbatch.slurm Outdated Show resolved Hide resolved
mgxd and others added 2 commits February 26, 2020 15:42
@mgxd @oesteban
Update docs/_static/sbatch.slurm
8c2953c 
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
@mgxd
DOC: add FAQ for existing FS results
75e6962
@effigies effigies added this to the 20.0.1 milestone Feb 27, 2020
@effigies
Copy link
Member

@oesteban All good?

oesteban
oesteban approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@oesteban oesteban merged commit fffe1b2 into nipreps:maint/20.0.x Feb 27, 2020
effigies added a commit that referenced this pull request Feb 27, 2020
@effigies
Merge tag '20.0.1'
6a64770 
20.0.1 (February 27, 2020)

Bug-fix release in 20.0.x series.

This release includes fixes for rare images with invalid qform matrices and some minor
improvements in report readability and inclusion of common templates in the Docker image.

  * FIX: Handle qforms with invalid quaternions (nipreps/niworkflows#466)
  * FIX: update niworkflows location (#2005)
  * ENH: Display errors as summary/details elements in reports (nipreps/niworkflows#464)
  * DOC: Add ``--fs-subjects-dir`` usage to slurm example (#2003)
  * CI: Test that Docker image can run a common set of output spaces without network access (#1997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.0.1
Development

Successfully merging this pull request may close these issues.

New --fs-subjects-dir - deep revision of documentation
3 participants
@mgxd @effigies @oesteban