-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Test that Docker image can run a common set of output spaces without network access #1997
Conversation
Thank your for raising your pull request. Some of the fMRIPRep maintainers will review your changes as soon as time permits. PR ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
Please check what applies in the following aspects of the PR: Code documentation
Documentation site
Tests
Data
Dependencies: smriprep
Dependencies: niworkflows
Dependencies: sdcflows
Dependencies: Nipype
Dependencies: other
Reports generated within CI tests
|
First failed. Merged in #1996. |
20.0.1 (February 27, 2020) Bug-fix release in 20.0.x series. This release includes fixes for rare images with invalid qform matrices and some minor improvements in report readability and inclusion of common templates in the Docker image. * FIX: Handle qforms with invalid quaternions (nipreps/niworkflows#466) * FIX: update niworkflows location (#2005) * ENH: Display errors as summary/details elements in reports (nipreps/niworkflows#464) * DOC: Add ``--fs-subjects-dir`` usage to slurm example (#2003) * CI: Test that Docker image can run a common set of output spaces without network access (#1997)
Changes proposed in this pull request
Let's reduce the odds of #1995 coming up again.
--network
option tofmriprep-docker
that allows us to pass the--network
option to Docker--network=none
for ds005, which uses AROMA, SyN-SDC, and outputs to a number of spaces including HCP-style CIFTI.Hopefully this will fail, and then will pass with #1996 in.
Documentation that should be reviewed