FIX: Check for valid qform before calculating change #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan
|
|
Hello @effigies, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2020-02-26 17:35:11 UTC |
effigies
force-pushed
the
fix/unbound_qform
branch
from
53c7ea2
to
2878576
Compare
|
Hard one to test. I don't know how to create a file that doesn't have a valid qform. I've asked the submitter to send me their header, and maybe we can do something there. |
effigies
force-pushed
the
fix/unbound_qform
branch
from
d2440f9
to
579c819
Compare
|
Now have full coverage of this interface. See https://codecov.io/gh/poldracklab/niworkflows/pull/466/src/niworkflows/interfaces/images.py?before=niworkflows/interfaces/images.py This is ready for a review. |
effigies
added a commit
to nipreps/fmriprep
that referenced
this pull request
Feb 27, 2020
20.0.1 (February 27, 2020) Bug-fix release in 20.0.x series. This release includes fixes for rare images with invalid qform matrices and some minor improvements in report readability and inclusion of common templates in the Docker image. * FIX: Handle qforms with invalid quaternions (nipreps/niworkflows#466) * FIX: update niworkflows location (#2005) * ENH: Display errors as summary/details elements in reports (nipreps/niworkflows#464) * DOC: Add ``--fs-subjects-dir`` usage to slurm example (#2003) * CI: Test that Docker image can run a common set of output spaces without network access (#1997)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #365. We were running into the case where
valid_qformwasFalse, and thusqformwas an unbound variable, but trying to compare the new qform to the old qform.This bug was introduced in 92e63fe, first released in 0.10.3. As this was included in fMRIPrep as of nipreps/fmriprep@b6d1e51, this bug is expected to affect versions 1.5.0-20.0.0 of fMRIPrep.
Fixes #465.